On Wed, May 18, 2016 at 10:06 AM, Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com> wrote: > On 17/05/2016 17:40, Thomas Monjalon wrote: >> >> 2016-05-12 00:44, Jianfeng Tan: >>> >>> This patch adds an option, --huge-trybest, to use a recover mechanism to >>> the case that there are not so many hugepages (declared in sysfs), which >>> can be used. It relys on a mem access to fault-in hugepages, and if fails >> >> relys -> relies >> >>> with SIGBUS, recover to previously saved stack environment with >>> siglongjmp(). >>> >>> Besides, this solution fixes an issue when hugetlbfs is specified with an >>> option of size. Currently DPDK does not respect the quota of a hugetblfs >>> mount. It fails to init the EAL because it tries to map the number of >>> free >>> hugepages in the system rather than using the number specified in the >>> quota >>> for that mount. >> >> It looks to be a bug. Why adding an option? >> What is the benefit of the old behaviour, not using --try-best? > > > I do not see any benefit to the old behavior. > Given that we need the signal handling for the cgroup use case, I would be > inclined to use > this method as the default instead of trying to figure out how many > hugepages we have free, etc.
+1 -- David Marchand
