<snip>
>                                            uint8_t stat_idx,
> @@ -1427,6 +1447,10 @@ struct eth_dev_ops {
>       eth_stats_reset_t          stats_reset;   /**< Reset generic device
> statistics. */
>       eth_xstats_get_t           xstats_get;    /**< Get extended device
> statistics. */
>       eth_xstats_reset_t         xstats_reset;  /**< Reset extended
> device statistics. */
> +     eth_xstats_names_t         xstats_names;
> +     /**< Get names of extended statistics. */
> +     eth_xstats_count_t         xstats_count;
> +     /**< Get number of extended statistics. */

Hi Remy
While reviewing the second patch in this patchset I noticed you aren't actually 
using 
eth_xstats_count_t   xstats_count in the eth_dev_ops to retrieve the count in 
the driver. 
Do you still need xstats_count?

BR
Maryam
<snip>

Reply via email to