2016-05-17 22:02, Mauricio V?squez: > On Fri, May 13, 2016 at 6:20 PM, Thomas Monjalon <thomas.monjalon at > 6wind.com> > wrote: > > 2016-04-29 17:23, Mauricio Vasquez B: > > > The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places > > > to check if a port id is valid or not. This commit makes use of it in > > > some new parts of the code. > > > > There are other occurences: > > rte_eth_dev_socket_id > > > I missed it. > > > rte_eth_add_rx_callback > > rte_eth_add_tx_callback > > rte_eth_remove_rx_callback > > rte_eth_remove_tx_callback > > > The macro can not be used on those ones because they set the rte_errno > variable before returning.
It may be a good idea to set rte_errno to EINVAL in these macros. Generally speaking, rte_errno is not used a lot currently.
