Hi all, Thanks for suggestions. I think the Oliver's first option is good. I introduce the new function and will replace rte_pktmbuf_detach() with it in a future release.
2016-05-16 18:13 GMT+09:00 Thomas Monjalon <thomas.monjalon at 6wind.com>: > 2016-05-16 11:46, Hiroyuki MIKITA: >> Now, the attach operation increases refcnt, but the detach does not decrease >> it. >> I think both operations should affect refcnt or not. >> Which design is intended? >> >> In "6.7. Direct and Indirect Buffers" of Programmer's Guide, >> it is mentioned that "...whenever an indirect buffer is attached to >> the direct buffer, >> the reference counter on the direct buffer is incremented. >> Similarly, whenever the indirect buffer is detached, >> the reference counter on the direct buffer is decremented." > > The doc is the reference. The doxygen comment should explicit every > details of the behaviour. > And the unit tests must validate every parts of the behaviour. > Probably there is a bug which is not (yet) tested. > Please see the function testclone_testupdate_testdetach. Thanks >
