> -----Original Message----- > From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net] > Sent: Monday, May 16, 2016 10:34 AM > To: dev at dpdk.org; thomas.monjalon at 6wind.com; Pattan, Reshma > <reshma.pattan at intel.com> > Subject: [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX > queues > > This allows releasing RX/TX queue memory. > --- > > Without this patch, this explicitly isn't allowed. Is there a particular > reason why it > shouldn't? It was introduced in > > d505ba80a165a9735f3d9d3c6ab68a7bd85f271b > > "ethdev: support unidirectional configuration" > > lib/librte_ether/rte_ethdev.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index > a31018e..5481d45 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -944,11 +944,6 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t > nb_rx_q, uint16_t nb_tx_q, > */ > (*dev->dev_ops->dev_infos_get)(dev, &dev_info); > > - if (nb_rx_q == 0 && nb_tx_q == 0) { > - RTE_PMD_DEBUG_TRACE("ethdev port_id=%d both rx and tx > queue cannot be 0\n", port_id); > - return -EINVAL; > - } > -
This was added to allow devices, at least with one direction (RX/TX) supported. As, devices with both directions disabled doesn't make sense right? Thanks, Reshma
