2016-05-12 08:55, Sergio Gonzalez Monroy: > On 11/05/2016 17:01, Daniel Mrzyglod wrote: > > Fix issue reported by Coverity. > > Coverity ID 97920 > > > > munmap structure of hugepage > > > > leaked_storage: Variable hugepage going out of scope leaks the storage > > it points to. > > > > The system resource will not be reclaimed and reused, reducing the future > > availability of the resource. > > I'm not really fond of this commit messages, but if no one minds them, > so be it.
Me too. It looks like a Machine2Machine message. I'd prefer an explanation of what is wrong first, then an explanation of the fix, and at the end, the Coverity ID (can be a tag like Fixes-Coverity-ID: 97920). > > In rte_eal_hugepage_init: Leak of memory or pointers to system resources > > > > Fixes: b6a468ad41d5 ("memory: add --socket-mem option") > > > > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod at intel.com>