On Thu, May 12, 2016 at 03:39:56PM +0000, Pattan, Reshma wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > > Sent: Saturday, May 7, 2016 4:16 PM > > To: dev at dpdk.org > > Cc: thomas.monjalon at 6wind.com; Richardson, Bruce > > <bruce.richardson at intel.com>; Jerin Jacob > > <jerin.jacob at caviumnetworks.com>; Maciej Czekaj > > <maciej.czekaj at caviumnetworks.com>; Kamil Rytarowski > > <Kamil.Rytarowski at caviumnetworks.com>; Zyta Szpak > > <zyta.szpak at semihalf.com>; Slawomir Rosek <slawomir.rosek at > > semihalf.com>; > > Radoslaw Biernacki <rad at semihalf.com> > > Subject: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and > > get_reg_length support > > > > + > > +static int > > +nicvf_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info > > +*regs) { > > + uint64_t *data = regs->data; > > + struct nicvf *nic = nicvf_pmd_priv(dev); > > + > > + if (data == NULL) > > + return -EINVAL; > > nicvf_reg_dump prints to stdout if data in NULL, so do we still want to > return here?
Yes as base is code common for other data plane libraries and I think in DPDK get_regs callback perspective it makes sense to add this check as PMD driver expected to get the data in the buffer. Thanks for the review. I agree with your all other review comments in another thread. Will fix it V2. > > Thanks, > Reshma > > >
