[dpdk-dev] [PATCH] librte_eal: fix wrong args operation in eal_parse_args

[Ziye Yang]

This patch is used to fix wrong operation on user
input args. eal_parse_args function should not operate
the args passed by the user. If the element in argv
is generated by malloc function, changing it  will cause
memory issues when free the args.

Signed-off-by: Ziye Yang <ziye.yang at intel.com>
---
 lib/librte_eal/bsdapp/eal/eal.c   | 2 --
 lib/librte_eal/linuxapp/eal/eal.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 06bfd4e..0eef92d 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -420,8 +420,6 @@ eal_parse_args(int argc, char **argv)
                goto out;
        }

-       if (optind >= 0)
-               argv[optind-1] = prgname;
        ret = optind-1;

 out:
diff --git a/lib/librte_eal/linuxapp/eal/eal.c 
b/lib/librte_eal/linuxapp/eal/eal.c
index 8aafd51..ba9d1ac 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -658,8 +658,6 @@ eal_parse_args(int argc, char **argv)
                goto out;
        }

-       if (optind >= 0)
-               argv[optind-1] = prgname;
        ret = optind-1;

 out:
-- 
1.9.3