-----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Monday, May 09, 2016 2:10 PM To: Hemant Agrawal <hemant.agrawal at nxp.com> Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a
2016-05-09 19:18, Hemant Agrawal: > This patch introduces dpaa2 machine target to address difference in > cpu parameter, number of core to 8 and no numa support w.r.t default > armv8-a machine > > Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com> [...] > --- /dev/null > +++ b/mk/machine/dpaa2/rte.vars.mk > +# ARCH = > +# CROSS = > +# MACHINE_CFLAGS = > +# MACHINE_LDFLAGS = > +# MACHINE_ASFLAGS = > +# CPU_CFLAGS = > +# CPU_LDFLAGS = > +# CPU_ASFLAGS = > +MACHINE_CFLAGS += -march=armv8-a > + > +ifdef CONFIG_RTE_ARCH_ARM_TUNE > +MACHINE_CFLAGS += -mcpu=$(CONFIG_RTE_ARCH_ARM_TUNE) endif There is nothing specific in this file. [Hemant] The arch is "armv8-a" instead of "armv8-a+crc". Also, we are using "mcpu" for ARM tuning. This is not present in the armv8a machine. The armv7a machine usages RTE_ARCH_ARM_TUNE to configure "mtune". > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > +#### Linaro toolchain usages arm64 instread of aarch64 in kernel ifeq > +($(ARCH), aarch64) ARCH = arm64 endif Could you provide more explanations please? aarch64 shouldn't be used I think. [Hemant] you are right. This is not required. I was using an old toolchain.