2016-03-31 13:14, Bruce Richardson: > On Thu, Mar 31, 2016 at 10:32:06AM +0100, Pablo de Lara wrote: > > This patches fixes some small issues in L2fwd-crypto > > app and also improves the app, making it more flexible > > (accepting different key sizes) > > and readable (information display improvement). > > > > Series-tested-by: Min Cao <min.cao at intel.com> > > > > Hi, > > Just some general advice: > > When someone is acking/resporting a tested-by for a patch series it's ok to > reply to the patch 0. > > However, for subsequent versions of the patchset itself, the acks and > tested-bys > should be placed on (all) the patches themselves, not in the cover letter. If > it's in the cover letter, you're forcing the applier of the patch to modify > each > one individually to stick on the extra information.
Yes More information about Tested-by: In general it doesn't apply to each patch. Example, here, I doubt it has to be added to the patch "add missing new line character in help". Thanks for adding the tag where relevant (by reading the test report). [...] > > Pablo de Lara (8): > > l2fwd-crypto: add missing new line character in help > > l2fwd-crypto: rename period parameter > > l2fwd-crypto: add missing string initialization > > l2fwd-crypto: fix length of random IV/AAD > > l2fwd-crypto: fix ambiguous input key size > > l2fwd-crypto: clarify key parsing in help > > l2fwd-crypto: use key-value list of supported algorithms > > l2fwd-crypto: extend crypto information
