On Fri, 18 Mar 2016 17:53:20 -0700 Rasesh Mody <rasesh.mody at qlogic.com> wrote:
> +static struct eth_dev_ops qede_eth_dev_ops = { > + .dev_configure = qede_dev_configure, > + .dev_infos_get = qede_dev_info_get, > + .rx_queue_setup = qede_rx_queue_setup, > + .rx_queue_release = qede_rx_queue_release, > + .tx_queue_setup = qede_tx_queue_setup, > + .tx_queue_release = qede_tx_queue_release, > + .dev_start = qede_dev_start, > + .dev_set_link_up = qede_dev_set_link_up, > + .dev_set_link_down = qede_dev_set_link_down, > + .link_update = qede_link_update, > + .promiscuous_enable = qede_promiscuous_enable, > + .promiscuous_disable = qede_promiscuous_disable, > + .allmulticast_enable = qede_allmulticast_enable, > + .allmulticast_disable = qede_allmulticast_disable, > + .dev_stop = qede_dev_stop, > + .dev_close = qede_dev_close, > + .stats_get = qede_get_stats, > + .mac_addr_add = qede_mac_addr_add, > + .mac_addr_remove = qede_mac_addr_remove, > + .vlan_offload_set = qede_vlan_offload_set, > + .vlan_filter_set = qede_vlan_filter_set, > + .flow_ctrl_set = qede_flow_ctrl_set, > + .flow_ctrl_get = qede_flow_ctrl_get, > +}; > + All eth_dev_ops structures should be marked const. It makes it harder for attacker to find a handle.