2016-03-18 16:22, Jerin Jacob: > On Fri, Mar 18, 2016 at 11:04:49AM +0100, Thomas Monjalon wrote: > > 2016-03-18 10:52, Tomasz Kulasek: > > > +#if !defined(NO_HASH_MULTI_LOOKUP) && defined(__ARM_NEON) > > > > I think we should use CONFIG_RTE_ARCH_ARM_NEON here. > > Any ARM maintainer to confirm? > > __ARM_NEON should work existing GCC, but it is better to use > RTE_MACHINE_CPUFLAG_NEON as > -it has been generated by probing the compiler capabilities. > -it's future-proof solution to support clang or other gcc versions in > future
I agree to use RTE_MACHINE_CPUFLAG_NEON. I just don't understand why CONFIG_RTE_ARCH_ARM_NEON has been introduced. It seems to be used to disable NEON on ARMv7: ifeq ($(CONFIG_RTE_ARCH_ARM_NEON),y) MACHINE_CFLAGS += -mfpu=neon endif