> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, March 11, 2016 7:20 PM > To: Panu Matilainen; Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether > type > > 2016-03-11 13:19, Panu Matilainen: > > On 03/11/2016 10:49 AM, Helin Zhang wrote: > > > -int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, uint16_t > > > tag_type); > > > +int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, > > > + enum rte_vlan_type vlan_type, > > > + uint16_t tag_type); > > > +int rte_eth_dev_set_vlan_ether_type_v22(uint8_t port_id, uint16_t > > > +tag_type); int rte_eth_dev_set_vlan_ether_type_v1604(uint8_t port_id, > > > + enum rte_vlan_type vlan_type, > > > + uint16_t tag_type); > > > > > > /** > > > * Set VLAN offload configuration on an Ethernet device > > > > Its nice to see people actually trying to be compatible on occasion :) > > > > However in this case there's not much point in doing so, because > > libethdev ABI has already been broken in this cycle: > > http://dpdk.org/browse/dpdk/commit/?id=cfd2279ea6299826fe992028f1dffaf > > 9fa7e7d0a > > > > In other words, the compatibility versions can never get invoked > > because all software built against libethdev needs to be rebuilt > > anyway because of the soname bump. Just drop the compat versions, no > > point carrying around something that cannot possibly get used. > > Oh yes, you are right. > Sorry Helin for having required that extra work. > On the good side, you have learnt how to do it ;)
Yes, as Thomas said, at leat l know how to do that, and the extra work was not too big. Thomas, Panu, thank you very much for the great comments! Thomas, does that mean I just need to work out a new version and just let the ABI changes as is. No ABI annoucenment will be requried? No RTE_NEXT_ABI will be used? Regards, Helin
