2016-03-10 11:57, Tomasz Kulasek: > +struct rte_eth_dev_tx_buffer { > + buffer_tx_error_fn callback; > + void *userdata;
What about renaming this fields as - error_callback - error_userdata ? > + uint16_t size; /**< Size of buffer for buffered tx */ > + uint16_t length; Maybe a comment "Number of packets in the array" to be sure? > + struct rte_mbuf *pkts[]; A comment? "Pending packets to be sent on explicit flush or when full" ? [...] > +DPDK_16.04 { > + global: > + > + rte_eth_tx_buffer_drop_callback; > + rte_eth_tx_buffer_count_callback; > + rte_eth_tx_buffer_init; > + rte_eth_tx_buffer_set_err_callback; Please keep alphabetical order.