Hi Panu, On 3/9/2016 10:46 AM, Panu Matilainen wrote: > On 03/09/2016 11:50 AM, David Hunt wrote: >> This patch is for those people who want to be easily able to switch >> between the new mempool layout and the old. Change the value of >> RTE_NEXT_ABI in common_base config file > > I guess the idea here is to document how to switch between the ABIs > but to me this reads as if this patch is supposed to change the value > in common_base. Of course there's no such change included (nor should > there be) here, but the description could use some fine-tuning perhaps. >
You're right, I'll clarify the comments. v4 due soon. >> >> v3: Updated to take re-work of file layouts into consideration >> >> v2: Kept all the NEXT_ABI defs to this patch so as to make the >> previous patches easier to read, and also to imake it clear what >> code is necessary to keep ABI compatibility when NEXT_ABI is >> disabled. > > Maybe its just me, but: > I can see why NEXT_ABI is in a separate patch for review purposes but > for final commit this split doesn't seem right to me. In any case its > quite a large change for NEXT_ABI. > The patch basically re-introduces the old (pre-mempool) code as the refactoring of the code would have made the NEXT_ABI additions totally unreadable. I think this way is the lesser of two evils. > In any case, you should add a deprecation notice for the oncoming ABI > break in 16.07. > Sure, I'll add that in v4. > - Panu - > Thanks for the comments, Regards, David.
