Hi David, On 02/29/2016 12:11 PM, Hunt, David wrote: >> Also, I'm sorry but it seems that several comments or question I've made >> in http://dpdk.org/ml/archives/dev/2016-February/032706.html are >> not addressed. >> >> Examples: >> - putting some part of the patch in separate commits >> - meaning of "rt_pool" >> - put_pool_bulk unclear comment >> - should we also have get_pool_bulk stats? >> - missing _MEMPOOL_STAT_ADD() in mempool_bulk() >> - why internal in rte_mempool_internal.h? >> - why default in rte_mempool_default.c? >> - remaining references to stack handler (in a comment) >> - ...? >> >> As you know, doing a proper code review takes a lot of time. If I >> have to re-check all of my previous comments, it will take even >> more. I'm not saying all my comments require a code change, but in case >> you don't agree, please at least explain your opinion so we can debate >> on the list. >> > Hi Olivier, > Sincerest apologies. I had intended in coming back around to your > original comments after refactoring the code. I will do that now. I did > take them into consideration, but I see now that I need to do further > work, such as a clearer name for rt_pool, etc. I will respond to your > original email.
I thought some comments were ignored :) So no problem in that case, thanks for clarifying. Olivier
