Hi, 2016-03-03 08:53, Simon K?gstr?m: > Hi! > > On 2016-03-03 05:08, Stephen Hurd wrote: > > Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps links
Stephen, you could be interested in the rework done by Marc Sune: http://dpdk.org/dev/patchwork/patch/10919/ > I realize this is a more general question, but is it really meaningful > to have macros for all possible link speeds? We're working on a PMD > driver with a channelized interface exposed as DPDK ports. Each channel > can be configured with an arbitrary speed, so e.g., 1337 Mbps is also > possible. What is the benefit? Why not negotiate the maximum capability of the peer? > To me, it would seem more natural to just have a number in mbits for the > link speed. Please jump in the thread initiated by Marc Sune months ago.