On 3/1/2016 11:10 PM, Stephen Hemminger wrote: > On Tue, 1 Mar 2016 15:41:58 +0000 > Ferruh Yigit <ferruh.yigit at intel.com> wrote: > >> +struct kcp_ethtool_msg { >> + int cmd_id; >> + int port_id; >> + unsigned int flag; >> + char input_buffer[KCP_ETHTOOL_MSG_LEN]; >> + char output_buffer[KCP_ETHTOOL_MSG_LEN]; >> + int input_buffer_len; >> + int output_buffer_len; >> + int err; >> +}; >> + > > In general try and use unsigned where ever it is possible. > Having int and char types was the C style back in Unix, but now > most code use size_t, uint32_t and uint8_t. > Thanks for the comments, this and previous ones, I will update accordingly.
> > You seem to be trying to force ethtool into netlink. > There are some others doing that already, so following their work > would be good. > Sure I would like to check them, where can I find them? inside the kernel? Thanks, ferruh