On 29/06/2016 17:18, Neil Horman wrote: > On Wed, Jun 29, 2016 at 04:12:21PM +0100, Remy Horton wrote: >> 'noon, [..] >> No licence..? >> > Its BSD, same as the others, I let the README cover that. We can include > it if we must, though we have lots of examples where we haven't bothered
Ok. The DPDK repo has a mix of BSD and GPL licenced files, so probably bit more critical than in other projects. > Nope, pep8 doesn't complain about this at all: > [nhorman at hmsreliant tools]$ pep8 ./pmdinfo.py > pmdinfo.py:573:80: E501 line too long (80 > 79 characters) > [nhorman at hmsreliant tools]$ Hmm.. [remy at VM tools]$ pep8 pmdinfo.py pmdinfo.py:19:1: E402 module level import not at top of file pmdinfo.py:20:1: E402 module level import not at top of file pmdinfo.py:21:1: E402 module level import not at top of file pmdinfo.py:23:1: E402 module level import not at top of file pmdinfo.py:24:1: E402 module level import not at top of file pmdinfo.py:25:1: E402 module level import not at top of file pmdinfo.py:26:1: E402 module level import not at top of file pmdinfo.py:27:1: E402 module level import not at top of file pmdinfo.py:28:1: E402 module level import not at top of file pmdinfo.py:32:1: E402 module level import not at top of file pmdinfo.py:33:1: E402 module level import not at top of file pmdinfo.py:42:1: E402 module level import not at top of file pmdinfo.py:43:1: E402 module level import not at top of file pmdinfo.py:44:1: E402 module level import not at top of file pmdinfo.py:49:1: E402 module level import not at top of file pmdinfo.py:51:1: E402 module level import not at top of file pmdinfo.py:573:80: E501 line too long (80 > 79 characters) [remy at VM tools]$ pep8 --version 1.7.0 To be fair the Python lot seem to add bucketloads of extra checks to PEP8/PyLint with every release. > As you note, none of these are catastrophic. I'm willing to fix them up, but > given, the number of iterations I've gone through for minior nits, I would > prefer to see it incorporated before I post this series again. I agree. Merge first and ask questions later.. :) ..Remy
