> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Tuesday, June 28, 2016 5:22 PM
> To: dev at dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> Subject: [dpdk-dev] [PATCH v2] ip_pipeline: add Python script file for
> creating visual diagram of IP pipeline config file
>
> This commit adds Python script for generating diagram of the application
> configuration file. This script requires graphviz package to be installed
> on the machine. The input config file is translated to an output file in
> DOT syntax, which is then used to create the image file using graphviz.
>
> To run the script, following command is used;
>
> ./diagram-generator.py -f <input configuration file>
>
> Some optional arguments are as follows:
> -h, --help show this help message and exit
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
The subject line is too long:
$ scripts/check-git-log.sh
Headline too long:
ip_pipeline: add Python script file for creating visual diagram of IP
pipeline config file
I would suggest something like:
ip_pipeline: add script for creating config diagrams
The code looks good though, so:
Acked-by: John McNamara <john.mcnamara at intel.com>
