On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: > In current i40e codebase, if single VLAN header is added in a packet, > it's treated as inner VLAN. Generally, a single VLAN header is > treated as the outer VLAN header. So change corresponding register > for single VLAN. > At the meanwhile, change the meanings of inner VLAN and outer VLAN. > > Signed-off-by: Beilei Xing <beilei.xing at intel.com> > --- > v2 changes: > Combine corresponding i40e driver changes into this patch. > > doc/guides/rel_notes/release_16_07.rst | 3 +++ > drivers/net/i40e/i40e_ethdev.c | 29 ++++++++++++++++++++--------- > lib/librte_ether/rte_ethdev.h | 4 ++-- > 3 files changed, 25 insertions(+), 11 deletions(-) > > diff --git a/doc/guides/rel_notes/release_16_07.rst > b/doc/guides/rel_notes/release_16_07.rst > index c0f6b02..ae02824 100644 > --- a/doc/guides/rel_notes/release_16_07.rst > +++ b/doc/guides/rel_notes/release_16_07.rst > @@ -135,6 +135,9 @@ API Changes > ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, > tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff. > > +* The meanings of ``ETH_VLAN_TYPE_INNER`` and ``ETH_VLAN_TYPE_OUTER`` in > + ``rte_vlan_type`` are changed. > +
This change of meaning is not a general change across the whole API but is just for the i40e driver. Rather than noting it as an API change, I think it's better documenting it as a "fixed issue" in the i40e driver. Also, I think it is better explained as a change in the type of a single vlan tag, rather than referring to it as a switch in meaning of inner and outer tags generally. Can you reword the message, please. /Bruce
