[dpdk-dev] [PATCH v12 0/3] mempool: add external mempool manager

[Hunt, David]

On 15/6/2016 1:03 PM, Olivier MATZ wrote:
> [...]
>
> The opaque pointer would be saved in mempool structure, and used
> when the mempool is populated (calling mempool_ops_alloc).
> The type of the structure pointed by the opaque has to be defined
> (and documented) into each mempool_ops manager.
>
>
> Olivier


OK, just to be sure before I post another patchset.....

For the rte_mempool_struct:
         struct rte_mempool_memhdr_list mem_list; /**< List of memory 
chunks */
+       void *ops_args;                  /**< optional args for ops 
alloc. */

(at the end of the struct, as it's just on the control path, not to 
affect fast path)

Then change function params:
  int
-rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name);
+rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name,
+               void *ops_args);

And (almost) finally in the rte_mempool_set_ops_byname function:
         mp->ops_index = i;
+       mp->ops_args = ops_args;
         return 0;

Then (actually) finally, add a null to all the calls to 
rte_mempool_set_ops_byname.

OK? :)

Regards,
Dave.