> -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, June 14, 2016 3:14 PM > To: De Lara Guarch, Pablo; dev at dpdk.org > Subject: RE: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from > fwd_config_display > > Hi Pablo, > > <snip> > > > > Subject: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from > > > fwd_config_display > > > > > > Add call to fwd_config_setup to init_config. > > > Remove fwd_config_setup from fwd_config_display. > > > Add call to fwd_config_setup for corelist, coremask and nbcore setup. > > > Add call to fwd_config_setup for portlist, portmask and nbport setup. > > > Add call to fwd_config_setup for rxq, txq, rxd and txd setup. > > > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com> > > > > Apologies for misleading here, but I think we should drop this patch for the > > moment. > > It is conflicting with another patch and it is not really necessary for your > > changes (am I right here?), so I would say best thing to do is to drop it > > and > > discuss if we want this change separately. > > This patch is needed for the patchset and should not be dropped. > > Is it conflicting with patch the following patch? > > http://dpdk.org/dev/patchwork/patch/13132/ > > This patch is renaming fwd_config_display to fwd_config_setup_display. > It clarifies what the function is doing, but does not address the issue of > separating the setup from the display. > > Separating the setup from the display is resolved in my patch.
Right, I thought this was only refactoring. Sorry about that! Anyway, since fwd_config_display() is going to call only pkt_fwd_config_display() now, it makes sense to move the code from that function to fwd_config_display(). You can send a separate patch for that, as it is only refactoring. Thanks, Pablo > > Regards, > > Bernard. > >
