On Mon, Jun 13, 2016 at 07:25:24PM +0530, Jerin Jacob wrote: > This patch set provides the initial version of DPDK PMD for the > built-in NIC device in Cavium ThunderX SoC family. > > Implemented features and ThunderX nicvf PMD documentation added > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst > respectively in this patch set. > > These patches are checked using checkpatch.sh with following > additional ignore option: > options="$options --ignore=CAMELCASE,BRACKET_SPACE" > CAMELCASE - To accommodate PRIx64 > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places > Hi Jerin,
other than the fact that patch 1 is very big, this set looks pretty ok to me. However, as a general comment on the series: the commit titles are overly low-level, as they refer too much to function/structure names e.g. patches 4 through 10. If you run the script "check-git-log.sh" on your patchset this will be flagged. What is expected in commit titles is that the change introduced by the path is explained without directly using the function names. Regards, /Bruce
