Hi Sergio,
Good catch, thanks. The patch looks ok, just few comments
on the commit log:
On 06/08/2016 05:10 PM, Sergio Gonzalez Monroy wrote:
> The mempool local cache is not being initialize properly leading to
'initialize' -> 'initialized' ?
and maybe 'is not being' -> 'was not' ?
> undefined behavior in cases where the allocated memory was used and left
> with data.
>
> Fixes: af75078fece3 ("first public release")
I think it fixes this one instead:
213af31e0960 ("mempool: reduce structure size if no cache needed")
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com>
> ---
> lib/librte_mempool/rte_mempool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_mempool/rte_mempool.c
> b/lib/librte_mempool/rte_mempool.c
> index b54de43..216514c 100644
> --- a/lib/librte_mempool/rte_mempool.c
> +++ b/lib/librte_mempool/rte_mempool.c
> @@ -787,7 +787,7 @@ rte_mempool_create_empty(const char *name, unsigned n,
> unsigned elt_size,
>
> /* init the mempool structure */
> mp = mz->addr;
> - memset(mp, 0, sizeof(*mp));
> + memset(mp, 0, MEMPOOL_HEADER_SIZE(mp, cache_size));
> ret = snprintf(mp->name, sizeof(mp->name), "%s", name);
> if (ret < 0 || ret >= (int)sizeof(mp->name)) {
> rte_errno = ENAMETOOLONG;
>
