2016-05-31 09:57, Neil Horman:
> +++ b/buildtools/Makefile
> @@ -0,0 +1,36 @@
> +# BSD LICENSE
> +#
> +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> +# All rights reserved.
I really think it is a strange copyright for a new empty file.
> +#if __x86_64__ || __aarch64__
Better to use CONFIG_RTE_ARCH_64.
> +#define TO_NATIVE(x) (x)
We already have some functions for endianness in
lib/librte_eal/common/include/generic/rte_byteorder.h
> +struct elf_info {
> + unsigned long size;
> + Elf_Ehdr *hdr;
> + Elf_Shdr *sechdrs;
> + Elf_Sym *symtab_start;
> + Elf_Sym *symtab_stop;
> + Elf_Section export_sec;
> + Elf_Section export_unused_sec;
> + Elf_Section export_gpl_sec;
> + Elf_Section export_unused_gpl_sec;
> + Elf_Section export_gpl_future_sec;
> + char *strtab;
The export_* fields are not used.
> --- /dev/null
> +++ b/mk/rte.buildtools.mk
I'm sorry I really do not agree it is a good practice to create a new
makefile type just for a new directory.
My opinion is that you should use and improve rte.hostapp.mk to make
it usable for possible other host apps.
