2016-05-31 14:35, Ferruh Yigit: > On 5/30/2016 5:46 PM, Ferruh Yigit wrote: > > On 5/30/2016 5:21 PM, Olivier Matz wrote: > >> Hi Ferruh, > >> > >> On 05/30/2016 05:49 PM, Ferruh Yigit wrote: > >>> On 5/30/2016 12:56 PM, Olivier Matz wrote: > >>>> The $(comma) variable is not defined in this Makefile, nor in > >>>> any included Makefile. Seen while doing a "make clean" on ubuntu: > >>>> > >>>> $ make clean > >>>> == Clean lib > >>>> == Clean lib/librte_compat > >>>> == Clean lib/librte_eal > >>>> == Clean lib/librte_eal/common > >>>> == Clean lib/librte_eal/linuxapp > >>>> == Clean lib/librte_eal/linuxapp/eal > >>>> == Clean lib/librte_eal/linuxapp/igb_uio > >>>> == Clean lib/librte_eal/linuxapp/kni > >>>> tr: missing operand after ?.-? > >>>> Two strings must be given when translating. > >>>> Try 'tr --help' for more information. > > Error is related to the kernel version, in second call "comma" > definition comes from kernel makefiles. > > Following commit causes comma to be defined: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=371fdc77af44f4cb32475fd499e1d912ccc30890 > > So this is valid issue for old kernels, and using "," directly looks OK. > > > Signed-off-by: Olivier Matz <olivier.matz at 6wind.com> > Acked-by Ferruh Yigit <ferruh.yigit at intel.com>
Applied, thanks
