Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, June 1, 2016 3:38 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei; rich.lane at bigswitch.com; mst at > redhat.com; > nakajima.yoshihiro at lab.ntt.co.jp; p.fedin at samsung.com; > ann.zhuangyanying at huawei.com; mukawa at igel.co.jp; > nhorman at tuxdriver.com > Subject: Re: [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup > > On Mon, May 30, 2016 at 10:55:33AM +0000, Jianfeng Tan wrote: > > Abstract vring hdr desc init as an inline method. > > What's this patch for then? In your last version, it will be invoked > twice, but it turned out to be wrong. So, why keeping this change? > I didn't see it improves anything. >
Yes, for now, only one version is kept because the position to call this function is changed. And I think this segment of code functions as a special purpose, which can be abstracted as a function, make sense? Thanks, Jianfeng
