> -----Original Message----- > From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com] > Sent: Thursday, July 21, 2016 3:51 AM > Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a > checksum > >... > > + Added a new function ``rte_pktmbuf_cksum()`` to process the checksum > > + of data embedded in an mbuf chain. > >... > > +#include <rte_ip.h> > > As a nit, do we need to introduce a dependency for librte_mbuf on librte_net? > Might be better to put this functionality into librte_net?
That's not a nit at all. This is clearly a net function that has no place in the mbuf code. That should be obvious even before we notice this circular dependency. -don dprovan at bivio.net
