> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 20, 2016 8:12 AM > To: Tootoonchian, Amin <amin.tootoonchian at intel.com> > Cc: dev at dpdk.org; Kerlin, MarcinX <marcinx.kerlin at intel.com> > Subject: Re: [dpdk-dev] [PATCH] ethdev: ensure consistent port id assignment > > Hi, > > 2016-07-20 15:07, Tootoonchian, Amin: > > Thomas, your thoughts? > > I have 2 thoughts: > - it is too big for 16.07 > - it is related to multi-process mechanism, maintained by Sergio ;) > > Sorry I won't look at it shortly.
[Adding Sergio to the thread for review.] The actual change of this patch is quite small (see below) but I understand that it may be too late for 16.07: * The main addition is getting the port id using rte_eth_dev_get_port_by_name for secondary processes in rte_eth_dev_allocate. Also zeroing out rte_eth_dev_data after freeing a port to avoid false positives in rte_eth_dev_get_port_by_name. * The rest of the patch moves parts of rte_eth_dev_allocate to be executed only by the primary.