> From: Remy Horton [mailto:remy.horton at intel.com] > Sent: Wednesday, July 06, 2016 12:44 AM > > > On 05/07/2016 19:10, Rasesh Mody wrote: > [..] > >> For all the current drivers xstats_names[idx].id==idx so it would > >> just involve removing the references to the id field and updating the > >> documentation. Complication is coordinating with QLogic for the bnx2x > >> & qede xstats patches. > > > > We could incorporate this change in our re-submission. > > The changes mentioned above have been merged in, so go ahead.. :)
We have submitted the QEDE and BNX2X PMD xstats patches with recent API changes. During the xstats change verification, it was observed that the order in which xstats names are fetched don't seem to match the order in which xstats values are fetched. When populating the xstats names, we order them as driver specific xstats names and then standard stats names. Whereas, while populating the xstats values, we populate the standard stats values and then the driver specific xstats values. In rte_eth_xstats_get_names(): xcount (or cnt_used_entries) + cnt_used_entries/count (RTE_NB_STATS + (dev->data->nb_rx_queues * RTE_NB_RXQ_STATS) + (dev->data->nb_tx_queues * RTE_NB_TXQ_STATS)) In rte_eth_xstats_get (): count (RTE_NB_STATS + (dev->data->nb_rx_queues * RTE_NB_RXQ_STATS) + (dev->data->nb_tx_queues * RTE_NB_TXQ_STATS)) + xcount Could you take a look? Thanks! Rasesh
