2016-01-28 10:11, Ferruh Yigit: > On Wed, Jan 27, 2016 at 07:05:52PM +0100, Thomas Monjalon wrote: > > 2016-01-25 10:01, Ferruh Yigit: > > > Remove "extern" keywords in header files, the ones for function > > > prototypes > > > > I've seen a lot of other extern keywords. Why not removing all? > > > Remaining one are Linux drivers in KNI, they are kind of internal headers, I > doubt on touching them. > Should I remove them all? > Also there are more usage in "drivers" folder, I am not sure touching them > too, what do you comment? > > > > -extern int rte_eth_dev_configure(uint8_t port_id, > > > - uint16_t nb_rx_queue, > > > - uint16_t nb_tx_queue, > > > - const struct rte_eth_conf *eth_conf); > > > +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue, > > > + uint16_t nb_tx_queue, > > > + const struct rte_eth_conf *eth_conf); > > > > The indent is weird. > > Why not follow the guideline with 2 tabs? > > http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation > > Intentionally kept them as original, to scope the patch just to remove a > keyword. > Do you want me fix the syntax wherever I touch for this patch?
Syntax? Do you mean to fix the indent? Yes I think it is a good practice to fix the indent when modifying some code.
