On Thu, Jan 28, 2016 at 7:15 AM, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote: > > On 27/01/2016 16:24, Ferruh Yigit wrote: > > > > > + default: > > > + ret = -95 /* EOPNOTSUPP */; > > > + break; > > > > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK).. > > > Return value is not significant, callee just checks for negative value, > I can remove comment to prevent confusion. > No, please fix the return value. Return values are significant when you are trying to debug or understand the intent of the code. Jay
