Hi Thomas, On 2/29/2016 5:12 AM, Thomas Monjalon wrote: > Hi, > > 2016-01-29 19:22, Jianfeng Tan: >> Current issue: DPDK is not that friendly to container environment, which >> caused by that it pre-alloc resource like cores and hugepages. But there >> are this or that resource limitations, for examples, cgroup, rlimit, >> cpuset, etc. >> >> For cores, this patch makes use of pthread_getaffinity_np to further >> narrow down detected cores before parsing coremask (-c), corelist (-l), >> and coremap (--lcores). >> >> For hugepages, this patch adds a recover mechanism to the case that >> there are no that many hugepages can be used. It relys on a mem access >> to fault-in hugepages, and if fails with SIGBUS, recover to previously >> saved stack environment with siglongjmp(). > They are some interesting ideas. > However, I am not sure a library should try to be so smart silently. > It needs more feedback to decide wether it can be the default behaviour > or an option. > > Please send coremask and hugepage mapping as separate patches as they > are totally different and may be integrated separately.
Good advise, thanks! I'll do it. And one more thing FYI, coremask using pthread_getaffinity_np() may have issue on some Linux versions or distros: it excludes isolcpus. This is reported by Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com>, and I'm still working it out. Thanks, Jianfeng > > Thanks