Hi, John, Best Regards, Mark
> -----Original Message----- > From: Mcnamara, John > Sent: Monday, February 22, 2016 9:47 PM > To: Chen, Jing D; dev at dpdk.org > Subject: RE: [PATCH v2] doc: add Vector FM10K introductions > > > -----Original Message----- > > From: Chen, Jing D > > Sent: Saturday, February 6, 2016 6:48 AM > > To: dev at dpdk.org > > Cc: Mcnamara, John <john.mcnamara at intel.com>; Chen, Jing D > > <jing.d.chen at intel.com> > > Subject: [PATCH v2] doc: add Vector FM10K introductions > > > > From: "Chen Jing D(Mark)" <jing.d.chen at intel.com> > > > > Add introductions on how to enable Vector FM10K Rx/Tx functions, the > > preconditions and assumptions on Rx/Tx configuration parameters. > > Hi Mark, > > Thanks for the update. A few minor comments below. > > > > > +Vector PMD (vPMD) uses Intel? SIMD instructions to optimize packet I/O. > > +It improves load/store bandwidth efficiency of L1 data cache by using a > > +wider SSE/AVX register 1 (1). > > This should probably be "register (1)" > > > > +The wider register gives space to hold multiple packet buffers so as to > > +save instruction number when processing bulk of packets. > > Maybe a little clearer as: > > The wider register gives space to hold multiple packet buffers so as to save > on the number of instructions when bulk processing packets. > > > > + > > +There is no change to PMD API. The RX/TX handler are the only two > > +entries for vPMD packet I/O. They are transparently registered at > > +runtime RX/TX execution if all condition checks pass. > > s/if all condition checks pass./if all conditions are met./ > > > > +As vPMD is focused on high throughput, it 4 packets at a time. So it > > s/it 4 packets at a time/it processes 4 packets at a time/ > > John Many thanks for the comments. I'll change and send a new version soon.
