On 02/22/2016 06:02 PM, Wiles, Keith wrote:
>> Hi Keith,
>>
>> What makes a param common?
>>
>> e.g. cryptodev QAT PMD is supported in linux, but currently not supported
>> in bsd.
>> So typically I disable it in the bsd file and enable it in the linux file.
>>
>> Couldn't the same apply to any other parameter, i.e. there may be users who
>> want to have differences in config for different OSs?
>>
>> So why not just leave as is and give users the option to choose?
>
> The problem is the major configs are all common, in this design we have the
> common_base all configs are placed then as you stated they are disable in the
> common_OS files. Plus some are enabled/disabled in the deconfig_XXX files as
> well.
>
> The goal is to move all of the configs into one file then we do not have to
> keep updating all of the common_OS files, but only enable/disable that option.
>
> I have common_osxapp that I want to add later to build and run DPDK on OS X,
> which is another place to have these same configs. Later we may add another
> OS too, which means more copies :-)
>
My +1 for eliminating config redundancy. In addition to improving
overall sanity, having the common options in a common file makes the few
actually OS-dependent items stand out, which is only a good thing.
- Panu -
