2016-02-20 07:40, Harish Patil: > This patch set introduces DPDK poll mode driver for new QLogic FastLinQ > QL4xxxx > 25G/40G capable family of CNAs as well as their SR-IOV Virtual Functions (VF). > > The overall PMD driver design includes a common module called ecore that deals > with the low level HW and a upper layer portion that provides the glue logic. > > Specifically, the ecore module contains all of the common logic, > e.g. initialization, cleanup, infrastructure for interrupt handling, link > management, slowpath etc. as well as protocol agnostic features and supplying > an abstraction layer for other modules. > > The higher layer implements DPDK exported APIs/driver entry points by > interfacing with the common module for configuration/status and also the > fastpath routines.
A new driver is always a good news :) Please could you share some performance numbers? What is the status about the integration of this driver in other environments? The layer named ecore seems to be what is named a base driver in other DPDK drivers. Maybe you could consider renaming the directory to base/ for consistency? About the format of the patches, I think it's better to split driver imports in several pieces to ease reviewing and later reference for specific bugs. What do you think of introducing basic features one by one?