This series addresses the post-merge review of the AMD NTB support by Stephen. Some of the issues also exist in the Intel code and in released versions; those patches are tagged for stable.
- Patches 1-4 fix the type confusion in rte_pmd_ntb_get_mem_align(), the unbounded peer memory window count, the off-by-one in the address remapping and the memory window leaks. - Patch 5 fixes the doorbell interrupts with vfio-pci: only MSI-X vector 0 (DB0) was serviced, so the DB1/DB2 exchange of dev_stop never completed and the stop waited for its 1s timeout. - Patch 7 removes the AMD hardware event handling, which could not run as wired, and documents that hardware events are not handled. - Patches 8-9 fix the Rx path: a partially consumed packet was leaked and desynchronized the ring, and an mbuf owned by the application could be freed again on device stop. - Patches 14-16 fix the peer device status accesses between the interrupt thread and the stop/data paths, and the missing checks and leaks at queue setup. - The other patches are documentation and cleanup. The peer memory window size check suggested for the AMD handshake is not added: all the AMD scratchpads are in use, and the window limit register programmed with the local memzone length already bounds what the peer can reach. Tested with vfio-pci on two AMD EPYC Embedded hosts: handshake, file transfer, and stop/quit with DB1/DB2 exchange. --- Changes since v2: - Resent with proper threading: in v2, all the patches replied to the v1 cover letter, so patchwork did not group them as a series and the CI could not apply them. No change in patches 1-15, apart from the rebase on current main. - Added patch 16 for the queue setup leaks reported by Stephen on v2. Changes since v1: - Patch 4: embed the memory window size array in struct ntb_hw instead of freeing it on close, as the device stays attached after close and mw_size could then be dereferenced as NULL. - Patch 5: allocate the doorbell interrupt handle array with calloc(), as it only holds process-private pointers. - Added patch 14 for the peer device status atomic accesses. - Added patch 15 for the queue setup checks, also covering the Tx side (unchecked nb_desc, and queue leak on invalid tx_free_thresh). Raghavendra Ningoji (16): raw/ntb: fix device check in memory alignment query raw/ntb: fix peer memory window count check raw/ntb: fix memory window bound in address remapping raw/ntb: fix memory leaks raw/ntb: fix doorbell interrupts with VFIO MSI-X raw/ntb: fix AMD processor names raw/ntb: remove AMD hardware event handling raw/ntb: fix Rx of incomplete packets raw/ntb: fix double free of Rx mbufs on stop examples/ntb: fix raw/ntb library linking doc: add NTB device info change to ABI section doc: add IOVA requirement for NTB raw/ntb: remove unused AMD register definitions raw/ntb: fix peer device status access raw/ntb: fix queue setup checks raw/ntb: fix queue leaks on setup doc/guides/rawdevs/ntb.rst | 12 +- doc/guides/rel_notes/release_26_11.rst | 6 +- drivers/raw/ntb/ntb.c | 266 ++++++++++++++++++------- drivers/raw/ntb/ntb.h | 17 +- drivers/raw/ntb/ntb_hw_amd.c | 60 +----- drivers/raw/ntb/ntb_hw_amd.h | 25 +-- drivers/raw/ntb/ntb_hw_intel.c | 17 +- examples/ntb/Makefile | 3 +- 8 files changed, 242 insertions(+), 164 deletions(-) -- 2.34.1
