On Wed, Jan 27, 2016 at 11:50:34AM +0800, Wang Xiao W wrote: > Correct typecast in fm10k_update_xc_addr_pf. > > Make functions that are only referenced locally static. > > And fix the function header comment for fm10k_tlv_attr_nest_stop() while > we're at it. > > Wrap fm10k_msg_data fm10k_iov_msg_data_pf[] in the new ifndef > NO_DEFAULT_SRIOV_MSG_HANDLERS so that drivers with custom SR-IOV > message handlers can strip it. > > remove unused struct element in struct fm10k_mac_ops. > > Signed-off-by: Wang Xiao W <xiao.w.wang at intel.com> > ---
>From the commit message it appears that a lot of things are being crammed into one patch. Please consider splitting it up, so that each commit just looks at doing one thing. If there are multiple one-line fixes, it's ok to put them into a single patch with a generic title like "misc small fixes", but for multi-line changes, it's best to have one change/fix per patch. Note also, that for commits fixing problems, a "fixes" line should be included in the commit message as documented here: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body Thanks, /Bruce
