On Fri, Dec 11, 2015 at 06:52:36PM +0000, Ananyev, Konstantin wrote: > > -----Original Message----- > > From: Stephen Hemminger [mailto:shemming at brocade.com] > > Sent: Friday, December 11, 2015 4:48 PM > > To: dev at dpdk.org; Zhang, Helin; Ananyev, Konstantin > > Subject: Re: [PATCH v2 ] ixgbe: speed up transmit > > > > On Fri, 13 Nov 2015 08:10:13 -0800 > > Stephen Hemminger <stephen at networkplumber.org> wrote: > > > > > From: Stephen Hemminger <shemming at brocade.com> > > > > > > The freeing of mbuf's in ixgbe is one of the observable hot spots > > > under load. Optimize it by doing bulk free of mbufs using code similar > > > to i40e and fm10k. > > > > > > Drop the no longer needed micro-optimization for the no refcount flag. > > > > > > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> > > > > How come this patch got no review or comments? > > It gets a visible performance gain of up to 10% in some cases. > > > > I understand maintainers are busy with internal work, but they need > > to read mailing list as well. > > Yep, I missed it somehow. > BTW, by some reason I couldn't find it patchwork.... > Was it submitted too late for 2.2 timeframe? > Anyway, about the patch itself: it looks good to me and indeed it provides > 10%+ > performance improvement. > So here is my ACK for it. > Konstantin
Applied to dpdk-next-net/rel_16_04, with edited title to clarify that it's the non-vectorized tx code that is being sped up, and not all ixgbe transmit paths. Thanks, /Bruce
