On Tue, Feb 09, 2016 at 05:09:06PM +0100, Wojciech Zmuda wrote: > Implement rte_pmd_af_packet_devuninit() exposed through struct > rte_driver.uninit() and set dev_flags to RTE_ETH_DEV_DETACHABLE, > to allow af_packet device deinitialization with API function > rte_eth_dev_detach(). This fixes memory leak by freeing memory > allocated during initialization. > During device initialization copy device name to ethdev->data to make > it compatible with rte_eth_dev_allocated(). > > Signed-off-by: Wojciech Zmuda <woz at semihalf.com> > --- > v2: > * Fixed typo and a comment. > * Added feature to the 2.3 release notes. > * Free memory allocated for rx and tx queues. > > doc/guides/rel_notes/release_2_3.rst | 4 ++++ > drivers/net/af_packet/rte_eth_af_packet.c | 37 > ++++++++++++++++++++++++++++++- > 2 files changed, 40 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/release_2_3.rst > b/doc/guides/rel_notes/release_2_3.rst > index 7945694..4694646 100644 > --- a/doc/guides/rel_notes/release_2_3.rst > +++ b/doc/guides/rel_notes/release_2_3.rst > @@ -39,6 +39,10 @@ This section should contain new features added in this > release. Sample format: > > Enabled virtio 1.0 support for virtio pmd driver. > > +* **Added af_packet driver deinitialization function.** > + > + Implemented rte_pmd_af_packet_devuninit() exposed through struct > + rte_driver.uninit() to allow af_packet device deinitialization with API > function. >
The use of "deinitialization" sounds awkward, and the overall text maybe could be made less technical. Maybe talk about "allowing dynamic removal" of af_packet devices [or even hotplug of them]? /Bruce
