On Fri, Jan 29, 2016 at 09:54:55AM +0530, Jerin Jacob wrote: > On Tue, Dec 08, 2015 at 03:03:34PM +0530, Jerin Jacob wrote: > > On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > > > 2015-12-07 19:52, Jerin Jacob: > > > > by default, all the targets will be configured with the 64-byte cache > > > > line > > > > size, targets which have different cache line size can be overridden > > > > through target specific config file. > > > > > > > > Selected ThunderX and power8 as CONFIG_RTE_CACHE_LINE_SIZE=128 targets > > > > based on existing configuration. > > > > > > > > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com> > > > > > > It looks good. > > > We are moving from a constant defined on CC command line in most cases > > > to a constant included in rte_config.h only. > > > Have you checked that the generated libraries are identical? > > > > Yes, Tested with a 64byte(x86_64-native-linuxapp-gcc) and a 128byte > > (arm64-thunderx-linuxapp-gcc) target. > > md5sum build/app/test comes same with or without patch. > > ping
Thomas, Can you review this, This is a long pending item. This rework based on your request. Jerin > > > > > > It would be good to have a check for POWER8. Chao? > > > Thanks
