Starting with MCFW version 1.4.0.8, Medford4 adapters support the use of the netport MCDI for port configuration by a VF; however, the MCDI which retrieves fixed port properties is not permitted for use by VFs.
Fill in dummy values sufficient for the DPDK driver to start on a VF. Signed-off-by: Ivan Malov <[email protected]> Reviewed-by: Andy Moreton <[email protected]> --- drivers/common/sfc_efx/base/efx_np.c | 41 +++++++++++++++++++++++++--- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_np.c b/drivers/common/sfc_efx/base/efx_np.c index f8b7e50695..bf0e639704 100644 --- a/drivers/common/sfc_efx/base/efx_np.c +++ b/drivers/common/sfc_efx/base/efx_np.c @@ -240,6 +240,7 @@ efx_np_get_fixed_port_props( __out_opt uint32_t *sup_cap_maskp, __out_opt efx_qword_t *loopback_cap_maskp) { + const efx_nic_cfg_t *encp = &enp->en_nic_cfg; EFX_MCDI_DECLARE_BUF(payload, MC_CMD_GET_FIXED_PORT_PROPERTIES_IN_LEN, MC_CMD_GET_FIXED_PORT_PROPERTIES_OUT_V2_LEN); @@ -247,6 +248,22 @@ efx_np_get_fixed_port_props( efx_mcdi_req_t req; efx_rc_t rc; + /* VFs do not allow access to the fixed port data. */ + if (EFX_PCI_FUNCTION_IS_VF(encp)) { + if (sup_cap_rawp != NULL) + memset(sup_cap_rawp, 0, MC_CMD_ETH_AN_FIELDS_LEN); + + if (sup_cap_maskp != NULL) + *sup_cap_maskp = 0; + + if (loopback_cap_maskp != NULL) { + memset(loopback_cap_maskp, 0, + sizeof (*loopback_cap_maskp)); + } + + return (0); + } + req.emr_out_length = MC_CMD_GET_FIXED_PORT_PROPERTIES_OUT_V2_LEN; req.emr_in_length = MC_CMD_GET_FIXED_PORT_PROPERTIES_IN_LEN; req.emr_cmd = MC_CMD_GET_FIXED_PORT_PROPERTIES; @@ -1058,10 +1075,6 @@ efx_np_attach( if (rc != 0) goto fail1; - /* - * FIXME: This may need revisiting for VFs, which - * don't necessarily have access to these details. - */ rc = efx_np_get_fixed_port_props(enp, epp->ep_np_handle, epp->ep_np_cap_data_raw, &epp->ep_phy_cap_mask, &epp->ep_np_loopback_cap_mask); @@ -1079,6 +1092,26 @@ efx_np_attach( epp->ep_phy_cap_mask |= 1U << EFX_PHY_CAP_AN; } + /* + * On VFs, 'efx_np_get_fixed_port_props' does not report any link + * speeds; indicate the auto-negotiation ability and construct + * the mask of theoretically supported link speed abilities. + * + * Also, indicate two flow control abilities that the VF cannot + * manage, but that can be safely assumed to be available. + */ + if (EFX_PCI_FUNCTION_IS_VF(encp)) { + unsigned int i; + + epp->ep_phy_cap_mask = 1U << EFX_PHY_CAP_AN | + 1U << EFX_PHY_CAP_PAUSE | 1U << EFX_PHY_CAP_ASYM; + + for (i = 0; i < EFX_ARRAY_SIZE(efx_np_cap_map_tech); ++i) { + epp->ep_phy_cap_mask |= + 1U << efx_np_cap_map_tech[i].encm_sw; + } + } + #if EFSYS_OPT_LOOPBACK efx_np_assign_loopback_props(enp); #endif /* EFSYS_OPT_LOOPBACK */ -- 2.47.3
