2016-02-04 09:47, Thomas Monjalon: > 2016-02-04 03:35, Wang, Zhihong: > > > Subject: [PATCH 1/3] eal/x86: fix build with clang for old AVX > > > > > > When configuring RTE_MACHINE to "default", rte_memcpy implementation > > > is the default one (old AVX). > > > In this code, clang raises a warning thanks to -Wsometimes-uninitialized: > > > > > > rte_memcpy.h:838:6: error: > > > variable 'srcofs' is used uninitialized whenever 'if' condition is false > > > if (dstofss > 0) { > > > ^~~~~~~~~~~ > > > rte_memcpy.h:849:6: note: uninitialized use occurs here > > > if (srcofs == 0) { > > > ^~~~~~ > > > > > > It is fixed by initializing srcofs to 0. > > > > > > Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512") > > > > Hi Thomas, > > > > Thanks for pointing this out! > > My last hasty modification on this is not correct. > > > > The patch below will fix it. All modifications are tested. > > Sorry for all the hassle! :'( > > > > "srcofs" should be calculated based on source address anyway. > > OK > Please send a full patch as usual, thanks.
Sorry I've just caught you have already sent it. Thanks