> -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, February 4, 2016 12:31 AM > To: Zhang, Helin <helin.zhang at intel.com> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization > failure > > On Wed, Dec 23, 2015 at 01:32:59PM +0800, Helin Zhang wrote: > > Workaround for the issue of cannot processing adminq commands during > > initialization, when 2x40G or 4x10G is receiving packets in highest > > throughput. Register 0x002698a8 and 0x002698ac should be cleared at > > first, and restored with the default values at the end. No more > > details, as they are not exposed registers. > > > > Signed-off-by: Helin Zhang <helin.zhang at intel.com> > > Hi Helin, > > can you please add an appropriately "fixes" line to the patch, since the > subject > explicitly calls it out as a bug-fix. Also, the words "the issue" in the > subject can > be removed as they don't add value. It would also be worthwhile referencing > the adminq in the subject too, since that is the failure being reported. How > about: > > "i40e: fix adminq failure on port init"
Oh, sorry, I forgot this patch. Firmware finally fixed it in FVL5, and we need to use new AQ commands for reading/writing some registers. So I will drop this patch. Thanks! Regards, Helin > > Regards, > /Bruce
