Internal APIs may be used for validating the internals of some component, but in general, it should be discouraged.
Let's not allow globally internal API in the unit tests. Signed-off-by: David Marchand <[email protected]> --- app/test/meson.build | 3 --- app/test/process.c | 2 ++ app/test/test_devargs.c | 2 ++ app/test/test_external_mem.c | 2 ++ app/test/test_malloc.c | 2 ++ app/test/test_mempool.c | 2 ++ app/test/test_pdump.c | 3 +++ app/test/virtual_pmd.c | 2 ++ 8 files changed, 15 insertions(+), 3 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index d8efa93050..e3dfa1d24c 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -286,9 +286,6 @@ foreach arg: extra_flags endif endforeach -# Enable using internal APIs in unit tests -cflags += '-DALLOW_INTERNAL_API' - # create a symlink in the app/test directory for the binary, for backward compatibility if not is_windows custom_target('test_symlink', diff --git a/app/test/process.c b/app/test/process.c index 2b6d7ae84b..92c8af702b 100644 --- a/app/test/process.c +++ b/app/test/process.c @@ -2,6 +2,8 @@ * Copyright(c) 2010-2014 Intel Corporation */ +#define ALLOW_INTERNAL_API + #include <errno.h> /* errno */ #include <limits.h> /* PATH_MAX */ #ifndef RTE_EXEC_ENV_WINDOWS diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c index 6c194ecfc6..66cf046463 100644 --- a/app/test/test_devargs.c +++ b/app/test/test_devargs.c @@ -2,6 +2,8 @@ * Copyright (c) 2021 NVIDIA Corporation & Affiliates */ +#define ALLOW_INTERNAL_API + #include <stdlib.h> #include <stdio.h> #include <string.h> diff --git a/app/test/test_external_mem.c b/app/test/test_external_mem.c index 53300983ed..2c8d0d8e00 100644 --- a/app/test/test_external_mem.c +++ b/app/test/test_external_mem.c @@ -2,6 +2,8 @@ * Copyright(c) 2018 Intel Corporation */ +#define ALLOW_INTERNAL_API + #include "test.h" #include <errno.h> diff --git a/app/test/test_malloc.c b/app/test/test_malloc.c index da868c8091..151d1a3f2c 100644 --- a/app/test/test_malloc.c +++ b/app/test/test_malloc.c @@ -2,6 +2,8 @@ * Copyright(c) 2010-2019 Intel Corporation */ +#define ALLOW_INTERNAL_API + #include "test.h" #include <stdio.h> diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c index e54249ce61..f1e8adeef9 100644 --- a/app/test/test_mempool.c +++ b/app/test/test_mempool.c @@ -2,6 +2,8 @@ * Copyright(c) 2010-2014 Intel Corporation */ +#define ALLOW_INTERNAL_API + #include <string.h> #include <stdio.h> #include <stdlib.h> diff --git a/app/test/test_pdump.c b/app/test/test_pdump.c index 64f1bbf21c..f1c9bd9d7e 100644 --- a/app/test/test_pdump.c +++ b/app/test/test_pdump.c @@ -1,6 +1,9 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2018 Intel Corporation */ + +#define ALLOW_INTERNAL_API + #include <stdio.h> #include <unistd.h> #include <stdint.h> diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index aa37e4073c..74bb3516ab 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -2,6 +2,8 @@ * Copyright(c) 2010-2014 Intel Corporation */ +#define ALLOW_INTERNAL_API + #include <rte_mbuf.h> #include <rte_ethdev.h> #include <ethdev_driver.h> -- 2.54.0
