Hi Michael, > -----Original Message----- > From: Qiu, Michael > Sent: Monday, February 1, 2016 4:32 PM > To: Yuanhan Liu; Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on > Intel X550 NIC > > On 2/1/2016 9:38 AM, Yuanhan Liu wrote: > > On Mon, Feb 01, 2016 at 01:04:52AM +0000, Lu, Wenzhuo wrote: > >> Hi, > >> > >>> -----Original Message----- > >>> From: Qiu, Michael > >>> Sent: Friday, January 29, 2016 3:16 PM > >>> To: Lu, Wenzhuo; dev at dpdk.org > >>> Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and > >>> forwarding on Intel X550 NIC > >>> > >>> Hi, Wenzhuo > >>> > >>> Better to explain what E-tag is, so that reviewers could known it. > >> Yes, it's better. But not sure where should I add this info. In release > >> note or > just cover letter? Any suggestion? Thanks. > > It should be done in the first patch introduced E-tag, so that it will > > be in the git log history. And of course, it does no harm at all to > > mention (briefly) it again in cover letter, so that > > reviewer/maintainer has a brief understanding of your whole patchset first. > > > > --yliu > > Yes, in my view, cover letter is a good place, but as want to be in git log > history, > it would be better to include in the right patch of the feature, because most > of > time, the first patch is not core related to new feature, perhaps only some > prepare code. > > > My opinion is to explain it where it first be mentioned in the code. I think it's good to explain it when we meet this concept at the first time. I'll do that. Thanks.
> > But again, it OK for Yuanhan's solution, the only thing you want to do is > think > you are a reviewer, and want to review you patch, what do you want. > > Thanks, > Michael
