Hi Ferruh, I agree that your solution is more flexible. I'll work on moving single thread creation to kni_ioctl_create next week and get back to you with results.
Regards, Vladyslav -----Original Message----- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Thursday, August 25, 2016 5:47 PM To: Vladyslav Buslov Cc: dev at dpdk.org Subject: Re: [PATCH] kni: add module parameter 'bind_to_core' Hi Vladyslav, On 8/16/2016 7:24 PM, Vladyslav Buslov wrote: > Allow binding KNI thread to specific core in single threaded mode. I think this is good idea. But I am not sure about making this a module parameter, setting core can be more dynamic. There is already a kni->core_id field, which is only used for multiple_kthread mode. What do you think moving single thread creation into kni_ioctl_create() and use first kni->core_id to bind the thread? If there is no kni->core_id set, it will behave as it is now. > > Signed-off-by: Vladyslav Buslov <vladyslav.buslov at harmonicinc.com> > --- <...>