The lcore ID verification is common for each cpufreq driver. So add this verification to framework.
Signed-off-by: Huisong Li <[email protected]> --- lib/power/rte_power_cpufreq.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/power/rte_power_cpufreq.c b/lib/power/rte_power_cpufreq.c index f63e976dc2..54872debfa 100644 --- a/lib/power/rte_power_cpufreq.c +++ b/lib/power/rte_power_cpufreq.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2010-2014 Intel Corporation */ - #include <eal_export.h> #include <rte_spinlock.h> #include <rte_debug.h> @@ -116,6 +115,7 @@ rte_power_init(unsigned int lcore_id) struct rte_power_cpufreq_ops *ops; uint8_t env; + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); if (global_default_env != PM_ENV_NOT_SET) return global_cpufreq_ops->init(lcore_id); @@ -147,6 +147,7 @@ RTE_EXPORT_SYMBOL(rte_power_exit) int rte_power_exit(unsigned int lcore_id) { + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); if (global_default_env != PM_ENV_NOT_SET) return global_cpufreq_ops->exit(lcore_id); @@ -161,6 +162,7 @@ uint32_t rte_power_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t n) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, 0); return global_cpufreq_ops->get_avail_freqs(lcore_id, freqs, n); } @@ -169,6 +171,7 @@ uint32_t rte_power_get_freq(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, RTE_POWER_INVALID_FREQ_INDEX); return global_cpufreq_ops->get_freq(lcore_id); } @@ -177,6 +180,7 @@ uint32_t rte_power_set_freq(unsigned int lcore_id, uint32_t index) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->set_freq(lcore_id, index); } @@ -185,6 +189,7 @@ int rte_power_freq_up(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->freq_up(lcore_id); } @@ -193,6 +198,7 @@ int rte_power_freq_down(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->freq_down(lcore_id); } @@ -201,6 +207,7 @@ int rte_power_freq_max(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->freq_max(lcore_id); } @@ -209,6 +216,7 @@ int rte_power_freq_min(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->freq_min(lcore_id); } @@ -217,6 +225,7 @@ int rte_power_turbo_status(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->turbo_status(lcore_id); } @@ -225,6 +234,7 @@ int rte_power_freq_enable_turbo(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->enable_turbo(lcore_id); } @@ -233,6 +243,7 @@ int rte_power_freq_disable_turbo(unsigned int lcore_id) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->disable_turbo(lcore_id); } @@ -242,5 +253,6 @@ rte_power_get_capabilities(unsigned int lcore_id, struct rte_power_core_capabilities *caps) { RTE_ASSERT(global_cpufreq_ops != NULL); + RTE_POWER_VALID_LCOREID_OR_ERR_RET(lcore_id, -1); return global_cpufreq_ops->get_caps(lcore_id, caps); } -- 2.33.0
