On Fri, Aug 26, 2016 at 3:39 AM, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> On 8/25/2016 8:03 PM, Ajit Khaparde wrote: > > > > > > On Thu, Aug 25, 2016 at 6:05 AM, Ferruh Yigit <ferruh.yigit at intel.com > > <mailto:ferruh.yigit at intel.com>> wrote: > > > > This line printed for every application even if driver is not used at > > all. Removing the line to reduce the noise. > > > > Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com > > <mailto:ferruh.yigit at intel.com>> > > --- > > drivers/net/bnxt/bnxt_ethdev.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > > b/drivers/net/bnxt/bnxt_ethdev.c > > index 3795fac..37d0322 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { > > > > static int bnxt_rte_pmd_init(const char *name, const char *params > > __rte_unused) > > { > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", > name); > > > > How about changing the log level to DEBUG? > > > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > + RTE_LOG(DEBUG, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > > > That should reduce the noise till the user explicitly changes the log > level. > > This will give similar result, this log is useless if you are not > debugging this driver, but debug log level can be enabled for many reasons. > > Other drivers use PMD_INIT_FUNC_TRACE() macros, which requires > specifically enabled in config for that driver. > There are other messages to aid tracing and debugging elsewhere in the code. So here goes.. Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com> ? > > > > > Thanks > > ? > > > > > > rte_eth_driver_register(&bnxt_rte_pmd); > > return 0; > > } > > -- > > 2.7.4 > > > > > >
